Just a small set of patches incorporating some comments from previous review. The new "Add FOREACH_CLIENT" commit was in response to Frediano's request to use a macro for looping through clients in his review of "Replace RedChannel::clients with GList". This new commit could be squashed into that one if necessary. Frediano Ziglio (2): move all item creation in main-channel-client.c change main_channel_marshall_mouse_mode call style Jonathon Jongsma (5): Move InputsChannelClient to a separate file Replace RedChannel::clients with GList RedChannel: Add FOREACH_CLIENT and use it to iterate Replace RedClient::channels with GList Limit direct access to DisplayChannelClient server/Makefile.am | 3 + server/dcc-encoders.c | 11 +- server/dcc-encoders.h | 4 +- server/dcc-private.h | 87 +++++++++++++++ server/dcc-send.c | 2 +- server/dcc.c | 59 ++++++++-- server/dcc.h | 93 ++++------------ server/display-channel.c | 84 +++++++-------- server/display-channel.h | 12 +-- server/image-cache.h | 1 - server/inputs-channel-client.c | 87 +++++++++++++++ server/inputs-channel-client.h | 48 +++++++++ server/inputs-channel.c | 80 ++++---------- server/inputs-channel.h | 4 +- server/main-channel-client.c | 43 ++++++-- server/main-channel-client.h | 15 +-- server/main-channel.c | 73 ++++--------- server/red-channel.c | 238 ++++++++++++++++++----------------------- server/red-channel.h | 18 +++- server/red-worker.c | 8 +- server/red-worker.h | 15 ++- server/stream.c | 79 +++++++------- server/stream.h | 2 +- 23 files changed, 608 insertions(+), 458 deletions(-) create mode 100644 server/dcc-private.h create mode 100644 server/inputs-channel-client.c create mode 100644 server/inputs-channel-client.h -- 2.4.11 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel