On Fri, 2016-03-11 at 10:26 +0100, Christophe Fergeau wrote: > On Thu, Mar 10, 2016 at 11:17:16AM -0600, Jonathon Jongsma wrote: > > This allows us to execute a custom mock acl helper binary for testing > > purposes. > > --- > > src/usb-acl-helper.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/src/usb-acl-helper.c b/src/usb-acl-helper.c > > index 20400eb..54b038b 100644 > > --- a/src/usb-acl-helper.c > > +++ b/src/usb-acl-helper.c > > @@ -198,7 +198,10 @@ void > > spice_usb_acl_helper_open_acl_async(SpiceUsbAclHelper *self, > > GIOStatus status; > > GPid helper_pid; > > gsize bytes_written; > > - gchar *argv[] = { (char*) ACL_HELPER_PATH"/spice-client-glib-usb-acl > > -helper", NULL }; > > + const gchar *acl_helper = g_getenv("USB_ACL_HELPER"); > > Can you prefix this with "SPICE_" ? > > Christophe Sure. Should I push with that change, or is anyone planning to do more reviews on any of these patches? Jonathon _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel