This does some minor cleanup to the SpiceUsbAclHelper class and adds some basic tests so that we can easily excercise more of its behavior. Differences to the previous series - use an environment variable to specify the mock acl helper binary instead of a GObject property - do a little API cleanup after getting a bit more familiar with the code - fixed a regression from the first patch where cancelling the GCancellable didn't actually result in the task being completed Jonathon Jongsma (6): Introduce spice_usb_acl_helper_cancel() usb-acl-helper: Avoid deadlock when cancelled Remove spice_usb_acl_helper_close_acl() Rename spice_usb_acl_helper_open_acl() to _open_acl_async() usb-acl-helper: add env var for specifying acl helper binary Add tests for usb-acl-helper src/channel-usbredir.c | 15 ++-- src/usb-acl-helper.c | 34 ++++---- src/usb-acl-helper.h | 12 +-- tests/Makefile.am | 15 ++-- tests/mock-acl-helper.c | 94 ++++++++++++++++++++ tests/usb-acl-helper.c | 226 ++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 360 insertions(+), 36 deletions(-) create mode 100644 tests/mock-acl-helper.c create mode 100644 tests/usb-acl-helper.c -- 2.4.3 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel