On Tue, Mar 01, 2016 at 12:42:20PM -0500, Frediano Ziglio wrote:
> > with QXLState an internal structure as well (defined in reds.h), and
> > RedDispatcher/RedQXL is one of the few members of this QXLState
> > structure. Should they be merged?
> >
>
> I think you should check patch 4/5 :)
Ah indeed, missed that one. Don't you mean QXLState rather than
RedsState in the shortlog though?
With this commit, we end up with
server/red-qxl.h:typedef struct QXLState RedQXL;
server/spice-qxl.h:typedef struct QXLState QXLState;
and
struct QXLState {} in red-qxl.c which holds the data for what we call
RedQXL throughout the file. I think it would be better to just use the
QXLState name everywhere and avoid introducing yet another name (we
already have QXLState, QXLInstance, QXLInterface, not having RedQXL in
addition to all of this sounds better to me.
Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel