Hi On Tue, Feb 16, 2016 at 5:50 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: > Marc-André, > > On Tue, Feb 16, 2016 at 3:49 PM, Marc-André Lureau > <marcandre.lureau@xxxxxxxxx> wrote: >> Using GtkGlArea is the proper way of doing opengl with gtk+ and solves >> virgl-client on wayland. Unfortunately, it requires spice-gtk to break ABI or >> API since the widget is a child of GtkDrawingArea and this is part of the ABI. >> We may want to introduce a new widget (new API), but then each and every >> application will need to handle the change. It seems better to avoid that by >> keeping the API but breaking our ABI. While at it, clean up a bunch of >> deprecated API and hide some ABI details away. > > I went through your patches and left some comments on the patches that > I didn't agree with something. thanks > About bumping gtk+ requirement to 3.16, hmm, I'm not exactly in favor > of this right now. I would like to have a release (any time soon) of > spice-protocol + spice-gtk and then I'd like to have those patches > applied. Does it make sense for you? Yes, that makes sense. 3.16 is almost a year old, I think starting depending on it upstream isn't such a hard requirement. In RHEL7 (if necessary), it might be possible to ask for it, since they have easier rebase rules these days. So, what I would agree with is releasing 0.31 with last gtk2 support, and drop gtk2 and release 0.32 (hopefully for f24). This way, virgl can work as well on x and wayland in next fedora. Note that we are nearing freezes so we must be quick with this plan. > By the way, I was not able to easily test this series on Windows. Have > you done this? I did, some time ago. Although it would be nice to check it again before the gtk3-only release. >> >> Marc-André Lureau (9): >> build-sys: bump spice-gtk current version info >> gtk: make SpiceDisplay private >> gtk: move gtk session >> gtk: move SpiceGrabSequence >> Drop GTK+ 2.0 >> gtk: drop deprecated stuff from spice-gtk >> gtk: require gtk+ 3.16 >> gtk: use GtkStack >> gtk: add GtkGLArea >> >> Makefile.am | 2 +- >> configure.ac | 148 +--------------------- >> doc/reference/Makefile.am | 2 +- >> spice-client-gtk-2.0.pc.in | 12 -- >> src/Makefile.am | 85 +------------ >> src/channel-display.c | 11 -- >> src/gtk-compat.h | 24 ---- >> src/spice-grabsequence-priv.h | 28 +++++ >> src/spice-grabsequence.c | 1 + >> src/spice-grabsequence.h | 13 -- >> src/spice-gtk-session-priv.h | 13 ++ >> src/spice-gtk-session.h | 33 ----- >> src/spice-widget-cairo.c | 20 --- >> src/spice-widget-egl.c | 9 ++ >> src/spice-widget-priv.h | 40 +++--- >> src/spice-widget-x11.c | 280 ------------------------------------------ >> src/spice-widget.c | 256 +++++++++++++++++--------------------- >> src/spice-widget.h | 42 ------- >> src/usb-device-widget.c | 16 +++ >> src/usb-device-widget.h | 36 ------ >> vapi/Makefile.am | 11 +- >> 21 files changed, 212 insertions(+), 870 deletions(-) >> delete mode 100644 spice-client-gtk-2.0.pc.in >> create mode 100644 src/spice-grabsequence-priv.h >> delete mode 100644 src/spice-widget-x11.c >> >> -- >> 2.5.0 >> >> _______________________________________________ >> Spice-devel mailing list >> Spice-devel@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel