Marc-André, On Tue, Feb 16, 2016 at 3:49 PM, Marc-André Lureau <marcandre.lureau@xxxxxxxxx> wrote: > Using GtkGlArea is the proper way of doing opengl with gtk+ and solves > virgl-client on wayland. Unfortunately, it requires spice-gtk to break ABI or > API since the widget is a child of GtkDrawingArea and this is part of the ABI. > We may want to introduce a new widget (new API), but then each and every > application will need to handle the change. It seems better to avoid that by > keeping the API but breaking our ABI. While at it, clean up a bunch of > deprecated API and hide some ABI details away. I went through your patches and left some comments on the patches that I didn't agree with something. About bumping gtk+ requirement to 3.16, hmm, I'm not exactly in favor of this right now. I would like to have a release (any time soon) of spice-protocol + spice-gtk and then I'd like to have those patches applied. Does it make sense for you? By the way, I was not able to easily test this series on Windows. Have you done this? > > Marc-André Lureau (9): > build-sys: bump spice-gtk current version info > gtk: make SpiceDisplay private > gtk: move gtk session > gtk: move SpiceGrabSequence > Drop GTK+ 2.0 > gtk: drop deprecated stuff from spice-gtk > gtk: require gtk+ 3.16 > gtk: use GtkStack > gtk: add GtkGLArea > > Makefile.am | 2 +- > configure.ac | 148 +--------------------- > doc/reference/Makefile.am | 2 +- > spice-client-gtk-2.0.pc.in | 12 -- > src/Makefile.am | 85 +------------ > src/channel-display.c | 11 -- > src/gtk-compat.h | 24 ---- > src/spice-grabsequence-priv.h | 28 +++++ > src/spice-grabsequence.c | 1 + > src/spice-grabsequence.h | 13 -- > src/spice-gtk-session-priv.h | 13 ++ > src/spice-gtk-session.h | 33 ----- > src/spice-widget-cairo.c | 20 --- > src/spice-widget-egl.c | 9 ++ > src/spice-widget-priv.h | 40 +++--- > src/spice-widget-x11.c | 280 ------------------------------------------ > src/spice-widget.c | 256 +++++++++++++++++--------------------- > src/spice-widget.h | 42 ------- > src/usb-device-widget.c | 16 +++ > src/usb-device-widget.h | 36 ------ > vapi/Makefile.am | 11 +- > 21 files changed, 212 insertions(+), 870 deletions(-) > delete mode 100644 spice-client-gtk-2.0.pc.in > create mode 100644 src/spice-grabsequence-priv.h > delete mode 100644 src/spice-widget-x11.c > > -- > 2.5.0 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel