On Fri, Jan 22, 2016 at 11:27 AM, Pavel Grunt <pgrunt@xxxxxxxxxx> wrote: > On Fri, 2016-01-22 at 10:59 +0100, Fabiano Fidêncio wrote: >> This typo was introduced by commit 5166f891e and unfortunately was >> not >> caught during the review. > > I did not consider it wrong, we have '#if USE_SMARTCARD' on one place > and "USE_*" is always defined with 1 as the value. > > I don't have a strong opinion about it, but if you wish to change it to > ifdef, do it for smartcard too. We have more cases like this in channel-usbredir.c as well. I'll leave it as it is for now and wait for more comments before taking any action. Best Regards, -- Fabiano Fidêncio _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel