Re: [PATCH] typo: use #ifdef instead of #if

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2016-01-22 at 10:59 +0100, Fabiano Fidêncio wrote:
> This typo was introduced by commit 5166f891e and unfortunately was
> not
> caught during the review.

I did not consider it wrong, we have '#if USE_SMARTCARD' on one place
and "USE_*" is always defined with 1 as the value.

I don't have a strong opinion about it, but if you wish to change it to
ifdef, do it for smartcard too.

Thanks,
Pavel

> ---
>  src/usb-device-manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> index 647edd0..6e12602 100644
> --- a/src/usb-device-manager.c
> +++ b/src/usb-device-manager.c
> @@ -393,7 +393,7 @@ static void
> spice_usb_device_manager_get_property(GObject     *gobject,
>          break;
>      case PROP_FREE_CHANNELS: {
>          int free_channels = 0;
> -#if USE_USBREDIR
> +#ifdef USE_USBREDIR
>          int i;
>          for (i = 0; i < priv->channels->len; i++) {
>              SpiceUsbredirChannel *channel = g_ptr_array_index(priv-
> >channels, i);
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]