On Fri, Nov 20, 2015 at 10:36:12AM -0600, Jonathon Jongsma wrote: > On Fri, 2015-11-20 at 17:15 +0100, Christophe Fergeau wrote: > > On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote: > > > I looked at this today, one different between glib log functions and > > > SPICE is that the SPICE ones append the file name/line number/function > > > name to the logged message. > > > > Thinking a bit more about this, while it's nice to have the function > > name/line number/..., the log message by itself usually makes it quite > > easy to find out where the log is coming from. > > > > We do have a macro like this in spice-gtk (SPICE_DEBUG()) that prepends the code > location and uses glib logging functions. But we manage to get along just fine > without that extra information in virt-viewer and many other glib applications. > I don't really consider this to be a critical feature. Agreed. Although I find useful using domains like this RFE for spice-gtk [1] :) [1] https://bugs.freedesktop.org/show_bug.cgi?id=91838 But only after we have GObjects in place... _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel