Re: [PATCH] log: add not fatal spice_return function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2015-11-20 at 17:15 +0100, Christophe Fergeau wrote:
> On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote:
> > I looked at this today, one different between glib log functions and
> > SPICE is that the SPICE ones append the file name/line number/function
> > name to the logged message.
> 
> Thinking a bit more about this, while it's nice to have the function
> name/line number/..., the log message by itself usually makes it quite
> easy to find out where the log is coming from.
> 

We do have a macro like this in spice-gtk (SPICE_DEBUG()) that prepends the code
location and uses glib logging functions. But we manage to get along just fine
without that extra information in virt-viewer and many other glib applications.
I don't really consider this to be a critical feature.

Jonathon

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]