On Fri, 2015-10-30 at 14:39 +0100, Christophe Fergeau wrote: > Hey, > > On Thu, Oct 29, 2015 at 04:54:40PM -0500, Jonathon Jongsma wrote: > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx> > > > > The specific item type that was not being handled was > > PIPE_ITEM_TYPE_INVAL_ONE (#102). This item type is used by the > > cursor > > channel, but the analogous item for the display channel is > > PIPE_ITEM_TYPE_INVAL_PALETTE_CACHE. Use this value instead. > > > > The exact warning follows: > > > > (/usr/bin/qemu-kvm:24458): Spice-Warning **: > > ../../server/dcc-send.c:2442:dcc_send_item: should not be > > reached > > (/usr/bin/qemu-kvm:24458): Spice-CRITICAL **: > > ../../server/dcc.c:1595:release_item_before_push: invalid item > > type > > Maybe I'm missing something, but it looks like the red_worker.c > changes > in this patch would cause these warnings if they are not accompanied > by > the cache_item.tmpl.c changes. > INVAL_ONE seems to mean "remove one cache > item" > INVAL_PALETTE_CACHE seems to be whole cache invalidation VS INVAL_ONE > which invalidates just one element in the cache. > > All in all, I'm not sure this patch is correct. > > Christophe Ugh. I look at this more closely now and I notice that the warning message from the commit log refers to dcc-send.c and dcc.c, which do not exist in the master branch. I think I need to investigate a bit more about what's going on here... _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel