I ended up splitting up this patch (03/11) into far more separate patches than I thought I would. But as I started reviewing, I realized that there's a lot of different things going on in this commit. Hopefully it's easier to review this way -- I know it helped me understand the patch much better. Of course, if people think that I was overly enthusiastic in my splitting, we can combine some of them... Obviously, the commit logs are my summary of the split changes, but I left Marc-Andre as the author of all of the patches. Marc-André Lureau (12): Store QXLInstance in CursorItem Make cursor_channel_disconnect a CursorChannel method Fix warning due to unexpected pipe item type Remove unused parameter from cursor_channel_new() Change red_marshall_verb() to accept a VerbItem common_channel_client_create -> common_channel_new_client __new_channel -> red_worker_new_channel() CursorChannel* arg in cursor_channel_client_new() Move pipe item enumerations out of red_worker.h Remove a couple single-use static functions Change some asserts to warnings Various minor style changes to worker and cursor channel server/cache_item.tmpl.c | 4 +- server/cursor-channel.c | 193 +++++++++++++++++++++++++--------------------- server/cursor-channel.h | 21 +++-- server/red_worker.c | 194 +++++++++++++++++++++-------------------------- server/red_worker.h | 62 +++++---------- 5 files changed, 230 insertions(+), 244 deletions(-) -- 2.4.3 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel