On Thu, 2015-09-24 at 16:21 +0200, Christophe Fergeau wrote: > On Thu, Sep 24, 2015 at 09:09:36AM -0500, Jonathon Jongsma wrote: > > On Thu, 2015-09-24 at 09:28 +0200, Christophe Fergeau wrote: > > > On Wed, Sep 23, 2015 at 10:35:26AM -0500, Jonathon Jongsma wrote: > > > > Some translatable strings were added in commit 8c37a340. > > > > --- > > > > po/POTFILES.in | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/po/POTFILES.in b/po/POTFILES.in > > > > index ad12609..ef1a2ee 100644 > > > > --- a/po/POTFILES.in > > > > +++ b/po/POTFILES.in > > > > @@ -6,3 +6,4 @@ src/spice-option.c > > > > src/usb-device-manager.c > > > > src/usb-device-widget.c > > > > src/usbutil.c > > > > +src/glib-compat.c > > > > > > Do we want to import the corresponding translation from glib ? (most > > > likely tedious work) > > > > I wouldn't bother. This function is actually only used to display a > > SPICE_DEBUG message on the terminal. In other words, users will not > > actually see it. I added it to POTFILES.in just to make distcheck happy. > > Ah ok, did not check where it was used... This should not be in > POTFILES.in then, as we don't want translators to translate it since > SPICE_DEBUG messages are not translated. POTFILES.skip instead? (but > when we start using this function in userr-visible strings, it won't be > translated :( Hmm, good point. I didn't think about POTFILES.skip. To be honest, I can't imagine needing to use this function for user-visible strings. That seems like something that only an application would usually need to do, not a library. So I'd prefer to add it to POTFILES.skip. Jonathon _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel