Hi,
On Thu, Jul 09, 2015 at 10:29:14AM -0400, Sandy Stutsman wrote:
> Hi All.
>
> On 6/25/2015 10:58 AM, Sandy Stutsman wrote:
> > Hello
> >
> > ----- Original Message -----
> >> From: "Marc-André Lureau" <mlureau@xxxxxxxxxx>
> >> To: "Sandy Stutsman" <sstutsma@xxxxxxxxxx>
> >> Cc: spice-devel@xxxxxxxxxxxxxxxxxxxxx
> >> Sent: Thursday, June 25, 2015 7:12:33 AM
> >> Subject: Re: [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config
> >>
> >> Hi
> >>
> >> ----- Original Message -----
> >>>> diff --git a/src/spice-widget.c b/src/spice-widget.c
> >>>> index 59f9792..3ec2e65 100644
> >>>> --- a/src/spice-widget.c
> >>>> +++ b/src/spice-widget.c
> >>>> @@ -293,7 +293,12 @@ static void update_monitor_area(SpiceDisplay
> >>>> *display)
> >>>> goto whole;
> >>>> }
> >>>>
> >>>> - update_area(display, c->x, c->y, c->width, c->height);
> >>>> + /* If only one head on this monitor, update the whole area */
> >>>> + if(monitors->len == 1) {
> >>>> + update_area(display, 0, 0, c->width, c->height);
> >>>> + } else {
> >>>> + update_area(display, c->x, c->y, c->width, c->height);
> >>>> + }
> >>> The linux qxl driver can't have a single monitor on (0,0)?
> >> On !(0,0), sorry.
> >>
> > I believe that for linux the primary monitor always has 0,0 origina and
> > if there is only a single monitor, it should be the primary one, yes?
> Did we ever decide on this? As it is, it is definitely broken for Windows multi-monitor guests. If single, primary monitor linux guests
> are always at (0,0), then this change should have no effect on them. I tried to find a counter case but was not successful. But I'm no linux expert...
I was testing this patch on Linux and I wasn't able to find any issues.
Tested on RHEL 6 and Fedora 22.
Maybe it is an unrelated bug but I get 'Waiting for display 2' a few
times on windows.
What I did:
On windows xp happend in the first boot after add new qxl device, the
second display showed the above message; Then I connected without your
patch and the second display worked; Then I connect with your patch
again and the second display was there; and now it is always present;
On my windows 7, I wasn't able to get second monitor. But I was able
with other windows 7 VM. Just odd... maybe qxl version is different.
Best,
- toso
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel