Hi All.
On 6/25/2015 10:58 AM, Sandy Stutsman wrote:
> Hello
>
> ----- Original Message -----
>> From: "Marc-André Lureau" <mlureau@xxxxxxxxxx>
>> To: "Sandy Stutsman" <sstutsma@xxxxxxxxxx>
>> Cc: spice-devel@xxxxxxxxxxxxxxxxxxxxx
>> Sent: Thursday, June 25, 2015 7:12:33 AM
>> Subject: Re: [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config
>>
>> Hi
>>
>> ----- Original Message -----
>>>> diff --git a/src/spice-widget.c b/src/spice-widget.c
>>>> index 59f9792..3ec2e65 100644
>>>> --- a/src/spice-widget.c
>>>> +++ b/src/spice-widget.c
>>>> @@ -293,7 +293,12 @@ static void update_monitor_area(SpiceDisplay
>>>> *display)
>>>> goto whole;
>>>> }
>>>>
>>>> - update_area(display, c->x, c->y, c->width, c->height);
>>>> + /* If only one head on this monitor, update the whole area */
>>>> + if(monitors->len == 1) {
>>>> + update_area(display, 0, 0, c->width, c->height);
>>>> + } else {
>>>> + update_area(display, c->x, c->y, c->width, c->height);
>>>> + }
>>> The linux qxl driver can't have a single monitor on (0,0)?
>> On !(0,0), sorry.
>>
> I believe that for linux the primary monitor always has 0,0 origina and
> if there is only a single monitor, it should be the primary one, yes?
Did we ever decide on this? As it is, it is definitely broken for Windows multi-monitor guests. If single, primary monitor linux guests
are always at (0,0), then this change should have no effect on them. I tried to find a counter case but was not successful. But I'm no linux expert...
-S
-S
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel