On 01/26/2015 01:48 AM, Javier Celaya wrote: > Sorry, I forgot to patch the command-line help. Hope it helps. > >>> >>> Recently, SPICE included the lz4 compression algorithm. This patch adds >>> a command line option to select it. >> >> How is libvirt going to introspect whether the command line supports >> this option? Is there some QMP command that lists the set of valid >> compression formats understood by a given qemu binary? No, patching the command line --help does NOT help libvirt. It needs to be discoverable via QMP to be introspectible, as scraping --help output is not machine-friendly. (That said, you DO want to expose it in --help output; I'm just complaining that --help output alone is not enough). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel