Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not exist before the commit that added this compression algorithm, so it should be guarded with conditional compilation. How do you think this should be done? Wait for the next stable version of spice-server and check for SPICE_SERVER_VERSION? Or add a specific flag? Thank you --- ui/spice-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/spice-core.c b/ui/spice-core.c index 6467fa4..fb6534e 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -359,6 +359,7 @@ static const char *compression_names[] = { [ SPICE_IMAGE_COMPRESS_QUIC ] = "quic", [ SPICE_IMAGE_COMPRESS_GLZ ] = "glz", [ SPICE_IMAGE_COMPRESS_LZ ] = "lz", + [ SPICE_IMAGE_COMPRESS_LZ4 ] = "lz4", }; #define parse_compression(_name) \ parse_name(_name, "image compression", \ -- 1.9.3 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel