Hey, On Thu, Jan 08, 2015 at 11:50:13AM +0100, Javier Celaya wrote: > Hello > > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not > exist before the commit that added this compression algorithm, so it should be > guarded with conditional compilation. How do you think this should be done? > Wait for the next stable version of spice-server and check for > SPICE_SERVER_VERSION? Or add a specific flag? Version check seems good, we probably can raise spice-server version in git preemptively so that you can have a working version check now. Given that lz4 support is optional, spice_server_set_image_compression should probably error out if we try to set lz4 but it's not supported. Christophe
Attachment:
pgpSbe9QYlZal.pgp
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel