On Mon, Dec 8, 2014 at 1:47 PM, Uri Lublin <uril@xxxxxxxxxx> wrote: >> With current workflow, you have no guaratee that unreviewed patch go >> there by mistake or maliciously. We would need a tool for that. >> For me this is the job of maintainer to quickly review each commit >> before release. > > > I disagree. > When doing a release, a maintainer should _not_ review all commits. > Those commits should have been reviewed before being committed. > The number of patches added since the previous release can be large, > and re-reviewing all of them can be too much work for little gain. This contradicts a bit the fact that you can do commit without review. I said "quickly", doing thorough review of all commits before a release is not doable. But it is the role of the maintainer to check all the commits that go in a repository, because we don't have ways to enforce that all patches are the one that are ack on ML. (and I don't think we need that, to me the process works well so far) -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel