On Fri, Nov 7, 2014 at 4:43 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote:
Having it in spice-gtk gives the functionality for free for another
clients than virt-viewer, right? I guess it's an enough good reason to
have it in spice-gtk instead of virt-viewer.
There are some reasons you may not want to use gtk bindings (modifier-key bindings, such as "ctrl+alt"), but in general, we should use gtk bindings, and this is what virt-viewer is doing for UI integration. So spice-gtk bindings are useless as soon as you try to ingrate properly. But having modifier-key bindings for this particular action probably makes sense. But then, why not share with the ungrab keybinding already mapping that (since there are few other binding options)?.
Getting back to the patch, disabling all inputs can be pretty annoying if you did it by accident. I was hoping for a more simple and less error-prone solution.
Getting back to the patch, disabling all inputs can be pretty annoying if you did it by accident. I was hoping for a more simple and less error-prone solution.
Christophe suggested something that seems better to me and avoid necessity for a second binding, it is detailed in https://bugs.freedesktop.org/show_bug.cgi?id=85331#c1
--
Marc-André Lureau
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel