Re: [PATCH xf86-video-qxl] In XSpice audio, fully clear the data structure; silences valgrind warnings.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



memset is fine with me. I'm also a bit curious about the warnings you
got, but I guess you no longer have these around.

I recall that one of the was the inodes array. Arguably, that was a bug, not just a warning silence. (Just a bug with a very low probability of triggering a problem).



But I need to break my grumpy K&R edition 1 only ways, so it'll be a good
exercise for me <grin>.

The memset(data.buffer, 0, data.buffer_bytes); call below becomes
redundant if I''m not mistaken.

No, that's malloc'd.  (I suppose it should probably be a calloc, but I'd
feel that would be out of scope for this patch).

Indeed it is, my bad.

ACK patch.

Thanks!

Cheers,

Jeremy
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]