Hey Christophe,
Thanks for the patch review.
+ memset(&data, 0, sizeof(data));
Could this be written as struct audio_data data = { 0, }; or something
like that?
Sure.
Note, though, that afaict, memset(...0...) seems more prevalent in the
spice code than the universal zero initializer.
But I need to break my grumpy K&R edition 1 only ways, so it'll be a
good exercise for me <grin>.
The memset(data.buffer, 0, data.buffer_bytes); call below becomes
redundant if I''m not mistaken.
No, that's malloc'd. (I suppose it should probably be a calloc, but I'd
feel that would be out of scope for this patch).
Cheers,
Jeremy
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel