----- Original Message ----- > On Mon, Nov 25, 2013 at 02:31:10PM +0100, Marc-André Lureau wrote: > > On Mon, Nov 25, 2013 at 1:41 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> > > wrote: > > > On Mon, Nov 25, 2013 at 01:33:52PM +0100, Marc-André Lureau wrote: > > >> Check that there is an actual stream before calling cork(). > > > > > > Is it expected that we are getting called with a non-NULL stream in the > > > first place? > > > > Since this is sent by server on mjpeg stream creation, I would say > > playback stream isn't mandatory. > > > > Anyway, it should not crash. > > Of course not, but we should fix things in the right place, hence the > question to know if this is the right place for that fix. > Your answer seems to be about playback_min_latency_changed(), what about > stream_uncork? Is this happening in the same situation? > No, there are checks for stream presence (it was checked everywhere, only since efa65b49f it didn't check for min-latency property changes) _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel