Re: [PATCH spice-gtk 4/4] canvas: use precomputed revers_bits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 12, 2013 at 01:32:07PM +0200, Marc-André Lureau wrote:
> On Wed, Sep 11, 2013 at 11:09 AM, Christophe Fergeau
> <cfergeau@xxxxxxxxxx> wrote:
> > On Tue, Sep 10, 2013 at 04:43:39PM +0200, Marc-André Lureau wrote:
> >> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
> >>
> >> Thos function shows up in some profiling results, it seems we can
> >> trivially replace it with a precomputed array of 256bytes.
> >
> > I forgot to ask, is the function less obvious in the profiling results
> > after your changes?
> >
> > Christophe
> 
> The test is a recoridng of XP cmd doing a recursive dir, for about 30%
> of the total recording time:
> (http://elmarco.fedorapeople.org/xp.xz)
> 
> before:
>      5.66%           691  lt-spicy-stats
> libspice-client-glib-2.0.so.8.4.0  [.] revers_bits
> after:
>      0.53%            64  lt-spicy-stats
> libspice-client-glib-2.0.so.8.4.0  [.] revers_bits
> 
> (fyi, 5% is about the same amount of cpu used for glz or quic decoding
> in this recording)

Ah, thanks, I did not expect hard numbers given your cover letter, let's
just add this data to the commit log then.

Christophe

Attachment: pgpkw4m3tMWgb.pgp
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]