On Wed, Sep 11, 2013 at 11:09 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Tue, Sep 10, 2013 at 04:43:39PM +0200, Marc-André Lureau wrote: >> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx> >> >> Thos function shows up in some profiling results, it seems we can >> trivially replace it with a precomputed array of 256bytes. > > I forgot to ask, is the function less obvious in the profiling results > after your changes? > > Christophe The test is a recoridng of XP cmd doing a recursive dir, for about 30% of the total recording time: (http://elmarco.fedorapeople.org/xp.xz) before: 5.66% 691 lt-spicy-stats libspice-client-glib-2.0.so.8.4.0 [.] revers_bits after: 0.53% 64 lt-spicy-stats libspice-client-glib-2.0.so.8.4.0 [.] revers_bits (fyi, 5% is about the same amount of cpu used for glz or quic decoding in this recording) -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel