Re: [PATCH spice-gtk] spice-pulse: Fix set_sink_input_volume() failed on seamless migration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 04/01/2013 11:11 PM, Marc-André Lureau wrote:
Hi


<snip>

I think we can agree that we should *never* deliberately call functions with
invalid parameters. So we need to *explicitly* check for nchannels == 0,
rather
then relying on pa_context_set_sink_input_volume to check this for us.

I agree, but keep a warning, a return_if_fail() would do too, in channel-playback.c / channel-record.c

Ok, one new patch implementing this coming up.

Regards,

Hans
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]