Re: [PATCH spice-gtk] spice-pulse: Fix set_sink_input_volume() failed on seamless migration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 04/01/2013 07:58 PM, Marc-André Lureau wrote:


----- Mensaje original -----
On seamless migration "switch-over" the playback_volume_changed callback gets
called, and at this time the channel object's nchannels property is 0,
leading to a warning like this:

(remote-viewer:8726): GSpice-WARNING **: set_sink_input_volume() failed:
Invalid argument

This patch fixes this.

Why is that? the nchannels property is set when receiving volume. Why does the server send a volume with 0 channels? Does that make sense? Shouldn't the fix be in the server instead?

A very valid question I tracked this down to a server bug, for which I
just send a patch.

Still I would like to push the trivial spice-gtk fix to silence the warning
upstream so, so as to silence it when using a new spice-gtk with an older
spice-server.

Regards,

Hams
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]