Re: [PATCH spice-gtk] channel: rely on couroutine instead of channel state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 12/02/2012 03:16 PM, Marc-André Lureau wrote:


On Sun, Dec 2, 2012 at 12:34 PM, Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>> wrote:

    Hmm, this seems like an unrelated change/fix and one which could do with its own
    commit message. Otherwise ack.


It's actually related, I removed a case in the current iterate_read() (I replaced with a pre-condition instead):

+    g_return_if_fail(c->state != SPICE_CHANNEL_STATE_MIGRATING)

-    case SPICE_CHANNEL_STATE_MIGRATING:
-        return;

Without that change, we might continue reading/handling incoming data during migration.

Ah, I see, ack for the original patch then.

Regards,

Hans


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]