Hi On Tue, May 8, 2012 at 12:51 PM, Uri Lublin <uril@xxxxxxxxxx> wrote: >>> Perhaps the header doesn't need to be conditionally excluded from the >>> list of files. > > > It is only used for Windows. > Is it simpler to always add it and only use it for Windows compilation ? >>> Also if it's not in the public API, it shouldn't be in the >>> libspice_client_glibinclude_HEADERS. > > > What is the appropriate list for WIN_USB_HDRS ? > > Not sure, but I think The header could go unconditionnaly in libspice_client_glib_2_0_la_SOURCES. If the file.c and the ifdef / includes are set right, that will not affect the build, if winusb is disabled. But it will make sure it is dist'ed. -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/spice-devel