Hi Marc-Andre,
Thanks for the quick and helpful review.
Some comments/questions (additional to Arnon's) are below.
On 05/08/2012 11:55 AM, Arnon Gilboa wrote:
Marc-André Lureau wrote:
Hi
On Mon, May 7, 2012 at 3:15 PM, Uri Lublin <uril@xxxxxxxxxx> wrote:
+WIN_USB_HDRS = \
+ win-usb-dev.h \
+ $(NULL)
+
Perhaps the header doesn't need to be conditionally excluded from the
list of files.
It is only used for Windows.
Is it simpler to always add it and only use it for Windows compilation ?
Also if it's not in the public API, it shouldn't be in the
libspice_client_glibinclude_HEADERS.
What is the appropriate list for WIN_USB_HDRS ?
+ usbdev->dev = libusb_ref_device(dev);
+ sprintf(usbdev->sclass, "%d", usbdev->desc.bDeviceClass);
+ sprintf(usbdev->sbus, "%d", libusb_get_bus_number(dev));
+ sprintf(usbdev->saddr, "%d", libusb_get_device_address(dev));
+ return TRUE;
In general snprintf() is preferred.
right
Patch 7 fixes that. We will merge those two patches into a single patch.
Thanks,
Uri.
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/spice-devel