On 28.06.23 17:51, Sam Ravnborg wrote: > On Wed, Jun 28, 2023 at 11:49:18AM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann <arnd@xxxxxxxx> >> >> An otherwise correct change to the atomic operations uncovered an >> existing bug in the sparc __arch_xchg() function, which is calls >> __xchg_called_with_bad_pointer() when its arguments are unknown at >> compile time: >> >> ERROR: modpost: "__xchg_called_with_bad_pointer" [lib/atomic64_test.ko] undefined! >> >> This now happens because gcc determines that it's better to not inline the >> function. Avoid this by just marking the function as __always_inline >> to force the compiler to do the right thing here. >> >> Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx> >> Link: https://lore.kernel.org/all/c525adc9-6623-4660-8718-e0c9311563b8@xxxxxxxxxxxx/ >> Fixes: d12157efc8e08 ("locking/atomic: make atomic*_{cmp,}xchg optional") >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > I assume you will find a way to apply the patch. Hmmm, looks to me like this patch is sitting here for two weeks now without having made any progress. From a quick search on lore it also looks like Dave is not very active currently. Hence: Arnd, is that maybe something that is worth sending straight to Linus? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.
