Hi, On Thu, May 4, 2023 at 8:02 PM Nicholas Piggin <npiggin@xxxxxxxxx> wrote: > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > These are tiny style changes: > > - Add a blank line before a "return". > > - Renames two globals to use the "watchdog_hld" prefix. > > Particularly static ones don't really need the namespace prefixes. Renames are mostly at Petr's request. If I've misunderstood what he wants here that I'm happy to remove them. > Not sure if processed is better than warn. I can undo this one if you want. It felt like we were doing more than just warning, but if people think "warn" is a better way to describe it then that's fine with me. > allcpu_dumped is better > than dumped_stacks though because the all-CPUs-dump is a particular > thing. OK, I can undo this and leave it as "allcpu_dumped". [1] https://lore.kernel.org/r/ZFErmshcrcikrSU1@alley
