Hi, On Thu, May 4, 2023 at 7:58 PM Nicholas Piggin <npiggin@xxxxxxxxx> wrote: > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > The perf hardlockup detector works by looking at interrupt counts and > > seeing if they change from run to run. The interrupt counts are > > managed by the common watchdog code via its watchdog_timer_fn(). > > > > Currently the API between the perf detector and the common code is a > > function: is_hardlockup(). When the hard lockup detector sees that > > function return true then it handles printing out debug info and > > inducing a panic if necessary. > > > > Let's change the API a little bit in preparation for the buddy > > hardlockup detector. The buddy hardlockup detector wants to print > > I think the name change is a gratuitous. Especially since it's now > static. > > watchdog_hardlockup_ is a pretty long prefix too, hardlockup_ > should be enough? > > Seems okay otherwise though. I went back and forth on names far too much when constructing this patch series. Mostly I was trying to balance what looked good to me and what Petr suggested [1]. I'm not super picky about the names and I'm happy to change them all to a "hardlockup_" prefix. I'd love to hear Petr's opinion. [1] https://lore.kernel.org/r/ZFErmshcrcikrSU1@alley
