Hi Thomas. One nitpick below. But other than that this is a nice cleanup: Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > +/* > + * Locations of MSI Registers. > + */ The SPARC way to format comments follows netdev style. So put it all in one line and everyone are happy: /* Locations of MSI Registers. */ > +#define MSI_MBUS_ARBEN 0xe0001008 /* MBus Arbiter Enable register */ > + > +/* > + * Useful bits in the MSI Registers. > + */ Likewise Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html