Hello, Thanks for the review. On Tue, 24 Jul 2018 16:37:36 +0200, Sam Ravnborg wrote: > One nitpick below. > But other than that this is a nice cleanup: > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > +/* > > + * Locations of MSI Registers. > > + */ > > The SPARC way to format comments follows netdev style. > So put it all in one line and everyone are happy: Well, the code is being moved from arch/sparc to arch/sparc, so apparently, it was already non-compliant to this specific coding style rule. Should the comments be made compliant as part of the same commit, or a separate one ? Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html