Re: [PATCH v1 07/13] sparc64: vcc: Enable LDC event processing engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Jag Raman <jag.raman@xxxxxxxxxx>
Date: Thu,  3 Aug 2017 13:43:59 -0400

> Enable event processing engine to handle LDC events
> 
> Signed-off-by: Jagannathan Raman <jag.raman@xxxxxxxxxx>
> Reviewed-by: Liam Merwick <liam.merwick@xxxxxxxxxx>
> Reviewed-by: Shannon Nelson <shannon.nelson@xxxxxxxxxx>
> ---
>  drivers/tty/vcc.c |   31 +++++++++++++++++++++++++++++++
>  1 files changed, 31 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c
> index 84a8dd7..8f4afdb 100644
> --- a/drivers/tty/vcc.c
> +++ b/drivers/tty/vcc.c
> @@ -443,8 +443,39 @@ static void vcc_tx_timer(unsigned long index)
>  	vcc_put(port, false);
>  }
>  
> +/**
> + * vcc_event() - LDC event processing engine
> + * @arg: VCC private data
> + * @event: LDC event
> + *
> + * Handles LDC events for VCC
> + */
>  static void vcc_event(void *arg, int event)
>  {
> +	struct vcc_port *port = (struct vcc_port *)arg;

Casts from void to other pointer types is never necessary, that's the
entire point of a void pointer.

So please remove this cast.

Please audit your entire submission for this issue.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux