Hi Davem. On Thu, Aug 03, 2017 at 02:57:48PM -0700, David Miller wrote: > From: Mikael Pettersson <mikpelinux@xxxxxxxxx> > Date: Thu, 3 Aug 2017 22:02:57 +0200 > > > With that in place the kernel booted fine. > > When I then ran the `poll' strace test binary, the OOPS was replaced by: > > > > [ 140.589913] _copy_from_user(fff000123c8dfa7c, (null), 240) res 240 > > [ 140.753162] _copy_from_user(fff000123c8dfa7c, 00000000f7e4a000, 8) res 8 > > [ 140.824155] _copy_from_user(fff000123c8dfa7c, 00000000f7e49ff8, 16) res 18442240552407530112 > > > > That last `res' doesn't look good. > > Please test this patch: > > diff --git a/arch/sparc/lib/U3memcpy.S b/arch/sparc/lib/U3memcpy.S > index 54f9870..5a8cb37 100644 > --- a/arch/sparc/lib/U3memcpy.S > +++ b/arch/sparc/lib/U3memcpy.S > @@ -145,13 +145,13 @@ ENDPROC(U3_retl_o2_plus_GS_plus_0x08) > ENTRY(U3_retl_o2_and_7_plus_GS) > and %o2, 7, %o2 > retl > - add %o2, GLOBAL_SPARE, %o2 > + add %o2, GLOBAL_SPARE, %o0 > ENDPROC(U3_retl_o2_and_7_plus_GS) > ENTRY(U3_retl_o2_and_7_plus_GS_plus_8) > add GLOBAL_SPARE, 8, GLOBAL_SPARE > and %o2, 7, %o2 > retl > - add %o2, GLOBAL_SPARE, %o2 > + add %o2, GLOBAL_SPARE, %o0 > ENDPROC(U3_retl_o2_and_7_plus_GS_plus_8) > #endif > Patch looks obviously correct, and I am a bit irritated that I did not see this myself. Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> I will send another patch that fixes/adds a few comments to the same file. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
