Hi Jim.
A few nitpicks.
On Thu, Jul 20, 2017 at 06:29:50AM -0400, Jim Quigley wrote:
> Using mpgroup to define multiple paths for a virtual disk causes multiple
> virtual-device-port ports to be created for that virtual device.
> Each virtual-device-port port then gets a vdisk created for it by the Linux
> sunvdc driver. As mpgroup is not supported by the Linux sunvdc driver it
> cannot handle multiple ports for a single vdisk, leading to a kernel panic
> at startup.
>
> This fix prevents more than one vdisk per virtual-device-port being created
> until full virtual disk multipathing (mpgroup) support is implemented.
>
> Signed-off-by: Jim Quigley <Jim.Quigley@xxxxxxxxxx>
> Reviewed-by: Shannon Nelson <shannon.nelson@xxxxxxxxxx>
> Reviewed-by: Alexandre Chartre <alexandre.chartre@xxxxxxxxxx>
> Reviewed-by: Aaron Young <aaron.young@xxxxxxxxxx>
> +
> +/*
> + * Determine whether the VIO device is part of an mpgroup
> + * by locating all the virtual-device-port nodes associated
> + * with the parent virtual-device node for the VIO device
> + * and checking whether any of these nodes are vdc-ports
> + * which have already been configured.
> + *
> + * Returns true if this device is part of an mpgroup and has
> + * already been probed.
> + */
This filel uses "netdev" style for comments.
Change coments to look like this:
/* Bla bla.
* More bla blah.
*/
> +static bool vdc_port_mpgroup_check(struct vio_dev *vdev)
> +{
> + struct vdc_check_port_data port_data;
> + struct device *dev;
> +
> + port_data.dev_no = vdev->dev_no;
> + port_data.type = (char *)&vdev->type;
Cast not needed?
Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
