Hi Dave, On Thu, 04 Aug 2011 01:21:46 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote: > > From: Josip Rodin <joy@xxxxxxxxxxxxxx> > Date: Thu, 28 Jul 2011 12:40:17 +0200 > > > This patch[0] seems to fix a build issue, but it doesn't fix the > > functionality - the previous change[1] changed the return value semantics, > > it's now supposed to be to be just the old value, rather than a comparison. > > > > [0] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=678624e401b0b7747762b5223fb23f86dcdacc93 > > [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=f24219b4e90cf70ec4a211b17fbabc725a0ddf3c > > Stephen please post a fix for this before a 32-bit sparc person > loses their filesystem or worse. Um, I could try to figure out how to do that, but what I did was respond in July 29 to the message above cc'ing the author of the orignal patch in the hope that they would write a fix. Clearly that hope was in vain :-( > The return value semantics have changed for this function, you > can't just put two underscores in front of the name, export > the symbol, and say "Ship it!" :-) Well, I never actaully said that about my original build fix patch. :-( -- Cheers, Stephen Rothwell sfr@xxxxxxxxxxxxxxxx http://www.canb.auug.org.au/~sfr/
Attachment:
pgpDCJaDyoEs4.pgp
Description: PGP signature
