Re: sparc: rename atomic_add_unless

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Josip Rodin <joy@xxxxxxxxxxxxxx>
Date: Thu, 28 Jul 2011 12:40:17 +0200

> This patch[0] seems to fix a build issue, but it doesn't fix the
> functionality - the previous change[1] changed the return value semantics,
> it's now supposed to be to be just the old value, rather than a comparison.
> 
> [0] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=678624e401b0b7747762b5223fb23f86dcdacc93
> [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=f24219b4e90cf70ec4a211b17fbabc725a0ddf3c

Stephen please post a fix for this before a 32-bit sparc person
loses their filesystem or worse.

The return value semantics have changed for this function, you
can't just put two underscores in front of the name, export
the symbol, and say "Ship it!" :-)
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux