Re: [PATCH 6/7] sparc32,leon: operate on boot-cpu IRQ controller registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Daniel Hellstrom wrote:

Josip Rodin wrote:

On Wed, Apr 20, 2011 at 11:06:54AM +0200, Sam Ravnborg wrote:
[PATCH]sparc32: always define boot_cpu_id

+extern unsigned char boot_cpu_id;
+unsigned char boot_cpu_id;
-unsigned char boot_cpu_id = 0;
-    int target_cpu = 0;
+    int target_cpu;
    target_cpu = boot_cpu_id;


You declared it, but you didn't actually define it?
There is an error in this patch, setup.h include is missing. I will repost.

I will not repost at this point. I think this is broken in sparc32 anyway. boot_cpu_id is always 0 because it is initialized before BSS is cleared, and boot_cpu_id is part of BSS. see arch/sparc/kernel/head_32.S

Daniel

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux