Re: [PATCH] sparc64: fix unused-but-set-variable warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 27, 2011 at 03:24:33PM -0800, David Miller wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Date: Sun, 27 Feb 2011 14:12:19 +0100
> 
> > On Sat, Feb 26, 2011 at 11:41:12PM -0800, David Miller wrote:
> >> +	/* We should probably check for hypervisor errors here and
> >> +	 * reset the LDC channel if we get one.
> >> +	 */
> > 
> > Coding style purist would say that the comment should look like this:
> 
> Not in my coding style.  That initial comment line is wasted space.
> 
> And a coding style purist would understand why that very rule
> goes aginst the proported reasoning behind the coding style
> rules (eliminating wasted space so more real information fits on
> the screen at once) and would thus have the rules fixed.
> 
> :-)
> 
> I will reject any future changes from you which add wasted vertical
> space like this, so please don't get into the habit of trying to inject
> this folly into either sparc or the networking, thanks.

OK

(And one day I may even start to use "//" for comments :-) )

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux