Re: [PATCH] sparc64: fix unused-but-set-variable warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 26, 2011 at 11:41:12PM -0800, David Miller wrote:
> 
> Here is the patch I will push upstream, it passes sparc64_defconfig,
> sparc64_defconfig + CONFIG_SMP=n, allnoconfig, and allmodconfig builds.

Looks good.

> +	/* We should probably check for hypervisor errors here and
> +	 * reset the LDC channel if we get one.
> +	 */

Coding style purist would say that the comment should look like this:

> +     /*
> +	 * We should probably check for hypervisor errors here and
> +      * reset the LDC channel if we get one.
> +      */

I do this for new stuff - and as part of other changes when I do
general clean-ups. It does not warrant an independet patch.

Patch is already pushed to kernel.org - so I do not expect any update.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [DCCP]     [Linux ARM Development]     [Linux]     [Photo]     [Yosemite Help]     [Linux ARM Kernel]     [Linux SCSI]     [Linux x86_64]     [Linux Hams]

  Powered by Linux