On Wed, Jan 26, 2011 at 05:37:22PM +0100, Daniel Hellstrom wrote:
> The way a LEON is powered down is implemented differently depending
> on CHIP type. The AMBA Plug&Play system ID tells revision of GRLIB
> and CHIP.
>
> This is for example needed by the GR-LEON4-ITX board and the UT699.
>
> Signed-off-by: Daniel Hellstrom <daniel@xxxxxxxxxxx>
It is not obvious for me how leon_pmc interact with the existing pmc.c
implmentation. I guess the latter fails during probe and is thus ignored.
Some comments below - mostly general or nitpick.
Sam
> +
> + /* Find System ID: GRLIB build ID and optional CHIP ID */
> + pp = of_find_property(rootnp, "systemid", &len);
> + if (pp)
> + amba_system_id = *(unsigned long *)pp->value;
> +
> + /*Find IRQMP IRQ Controller Registers base address otherwise bail out.*/
If you are going to resubmit then fix this comment (add a space)
> + * Copyright (C) 2011 Daniel Hellstrom (daniel@xxxxxxxxxxx) Aeroflex Gaisler AB
> + */
> +
> +#include <linux/pm.h>
> +#include <linux/init.h>
> +#include <asm/leon.h>
> +#include <asm/leon_amba.h>
For this number of includes it does not matter.
But in general we use the inverse christmas tree way.
Longer lines first. Lines with identical length sorted alphabetically.
And an empty line between the include groups.
> +/*
> + * CPU idle callback function for systems that need some extra handling
> + * See .../arch/sparc/kernel/process.c
> + */
> +void pmc_leon_idle_fixup(void)
> +{
> + /* Prepare an address to a non-cachable region. APB is always
> + * none-cachable. One instruction is executed after the Sleep
> + * instruction, we make sure to read the bus and throw away the
> + * value by accessing a non-cachable area, also we make sure the
> + * MMU does not get a TLB miss here by using the MMU BYPASS ASI.
> + */
> + register unsigned int address = (unsigned int)leon3_irqctrl_regs;
> + __asm__ __volatile__ (
> + "mov %%g0, %%asr19\n"
> + "lda [%0] %1, %%g0\n"
> + :
> + : "r"(address), "i"(ASI_LEON_BYPASS));
> +}
Good to see the rasons commented!
> +
> +/* This driver is not critical to the boot process, don't care
> + * if initialized late.
> + */
> +__initcall(leon_pmc_install);
We do not use __initcall() in new code.
Use the appropriate initcall from init.h.
A patch to fix up rest of sparc is welcome :-)
Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
