On Tue, 2011-01-18 at 15:13 -0500, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@xxxxxxxxxxx) wrote:
> > On Tue, 2011-01-18 at 13:16 -0500, Steven Rostedt wrote:
> > > On Tue, 2011-01-18 at 12:33 -0500, Steven Rostedt wrote:
> > > > On Tue, 2011-01-18 at 11:46 -0500, Mathieu Desnoyers wrote:
> > >
> > > > > Also align TRACE_PRINTKS on 8 bytes to make sure the beginning of the section is
> > > > > aligned on pointer size.
> > > >
> > > > If I can make it crash without the alignments and this fixes the issue,
> > > > I'll apply both patches.
> > >
> > > After applying David's patch, I do indeed get a crash. I'll now apply
> > > yours and see if it fixes the issue.
> >
> > Your patch doesn't seem to fix it either. I'll investigate this further.
>
> I think David's patch missed kernel/trace/trace_export.c
>
> struct ftrace_event_call __used \
> __attribute__((__aligned__(4))) \
> __attribute__((section("_ftrace_events"))) event_##call = { \
>
> and kernel/trace/trace.h:
>
> #define FTRACE_ENTRY(call, struct_name, id, tstruct, print) \
> extern struct ftrace_event_call \
> __attribute__((__aligned__(4))) event_##call;
>
> does it help if you remove these ?
I doubt it, but I'll try it anyway.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
