On Thu, Jan 6, 2011 at 10:36, David Miller <davem@xxxxxxxxxxxxx> wrote: > From: Julian Calaby <julian.calaby@xxxxxxxxx> > Date: Thu, 6 Jan 2011 10:23:43 +1100 > >> And beyond that, keeping these (unnecessary) #ifdefs is good >> documentation - it makes it obvious that these drivers require sbus to >> function. > > It should be buildable on any platform that has CONFIG_OF support, > as all of the SBUS drivers only use generic OF and dma_*() interfaces. > > And this has value because it increases build testing. Oh, yes, forgot that =) That said, sunhme has SBUS conditionals around calls to sbus_can_burst64() and sbus_can_dma_64bit() - I'm not sure if the other drivers also use similar functions to determine what they can / should do and whether this would break things. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
