On Thu, Jan 6, 2011 at 08:02, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Kristoffer Glembo noticed that SBUS is always defined for SPARC. > So I went out and dropped all #ifdef SBUS that were > present in SPARC only code. Good catch, but is this necessarily correct - i.e. do all sparc machines have sbus hardware, and is it necessary to have sbus support compiled into all sparc kernels? - should this be a (hidden) compile option in like most other bus types? (e.g. PCI) And beyond that, keeping these (unnecessary) #ifdefs is good documentation - it makes it obvious that these drivers require sbus to function. Would it potentially be a better choice to drop the SPARC dependency as it's the only architecture that defines SBUS? Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
