On Sat, 9 Oct 2010 23:13:24 -0600 Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: > On Sat, Oct 09, 2010 at 01:48:08PM -0700, Andres Salomon wrote: > > On Sat, 9 Oct 2010 02:51:43 -0600 > > Grant Likely <grant.likely@xxxxxxxxxxxx> wrote: > > [...] > Hmmm, series fails to build on sparc32, and doesn't appear to be > fully bisectable. Patches 1-3 compile file. Adding patch 4 gives Thanks for testing! > the following build error. Missing include perhaps? > > /home/grant/hacking/linux-2.6/drivers/of/pdt.c: In function > 'build_one_prop': /home/grant/hacking/linux-2.6/drivers/of/pdt.c:80: > error: implicit declaration of function > 'prom_firstprop' /home/grant/hacking/linux-2.6/drivers/of/pdt.c:80: > warning: assignment makes pointer from integer without a > cast /home/grant/hacking/linux-2.6/drivers/of/pdt.c:82: error: > implicit declaration of function > 'prom_nextprop' /home/grant/hacking/linux-2.6/drivers/of/pdt.c:82: > warning: assignment makes pointer from integer without a > cast /home/grant/hacking/linux-2.6/drivers/of/pdt.c:92: error: > implicit declaration of function > 'prom_getproplen' /home/grant/hacking/linux-2.6/drivers/of/pdt.c:99: > error: implicit declaration of function > 'prom_getproperty' /home/grant/hacking/linux-2.6/drivers/of/pdt.c: In > function > 'prom_build_tree': /home/grant/hacking/linux-2.6/drivers/of/pdt.c:213: > error: implicit declaration of function > 'prom_getchild' /home/grant/hacking/linux-2.6/drivers/of/pdt.c:218: > error: implicit declaration of function 'prom_getsibling' > distcc[16086] ERROR: > compile /home/grant/hacking/linux-2.6/drivers/of/pdt.c on localhost > failed make[3]: *** [drivers/of/pdt.o] Error 1 make[2]: *** > [drivers/of] Error 2 make[2]: *** Waiting for unfinished jobs.... > > And after applying patch 5, I get this instead: > > cc1: warnings being treated as errors > /home/grant/hacking/linux-2.6/arch/sparc/kernel/prom_common.c: In > function > 'prom_common_nextprop': /home/grant/hacking/linux-2.6/arch/sparc/kernel/prom_common.c:144: > error: passing argument 2 of 'prom_nextprop' discards qualifiers from > pointer target > type /home/grant/hacking/linux-2.6/arch/sparc/include/asm/oplib_32.h:227: > note: expected 'char *' but argument is of type 'const char *' > make[2]: *** [arch/sparc/kernel/prom_common.o] Error 1 make[2]: *** > Waiting for unfinished jobs.... > D'oh: arch/sparc/include/asm/oplib_32.h:extern char *prom_nextprop(phandle node, char *prev_property, char *buffer); arch/sparc/include/asm/oplib_64.h:extern char *prom_nextprop(phandle node, const char *prev_property, char *buf); > And applying the subsequent patches fails with the same error. > Sparc64 builds fine with the entire stack applied, but I haven't > bisected and I suspect that patch 4 will still fail there. > > So, I'll leave patches 1-3 in my tree, and drop 4-7 until you get it > sorted out. I'll go ahead and resend 4-8 once I fix 'em up; the nextprop fix require modifications to 5 and 8, and I haven't fixed the problem w/ 4 yet. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
