Hi Sam,
Try it on the individual patches you submitted.
scripts/checpatch.pl name-of-patch
Have you tried to run sparse?
It may flag potential stuff that needs fixing too.
Sam
I have cleaned up the new patches (submitted as "round 4") through
checkpatch and sparse. Below the outputs.
------------------------------
0001-sparc-leon-CONFIG_SPARC_LEON-option-and-leon-specifi.patch: total: 0 errors, 25 warnings, 1102 lines checked
All warning 80 chars/line. Cannot be removed unless layout be destroyed.
------------------------------
0002-sparc-leon-Redefine-MMU-register-access-asi-if-CONFI.patch: total: 0 errors, 0 warnings, 11 lines checked
------------------------------
0003-sparc-leon-Introduce-the-sparc-leon-CPU-type.patch:
WARNING: line over 80 characters
#87: FILE: arch/sparc/include/asm/prom.h:121:
+extern void (*prom_build_more)(struct device_node *dp, struct device_node ***nextp);
WARNING: printk() should include KERN_ facility level
#204: FILE: arch/sparc/kernel/setup_32.c:262:
+ printk("LEON\n");
total: 0 errors, 2 warnings, 158 lines checked
The "printk("LEON\n");" comes from
.....
case sun4u:
printk("SUN4U\n");
break;
case sparc_leon:
printk("LEON\n");
break;
default:
printk("UNKNOWN!\n");
break;
....
------------------------------
cripts/checkpatch.pl 0004-sparc-leon-Added-support-for-AMBAPP-bus.patch
total: 0 errors, 0 warnings, 146 lines checked
------------------------------
cripts/checkpatch.pl 0005-sparc-leon-sparc-leon-specific-SRMMU-initialization-.patch
total: 0 errors, 0 warnings, 74 lines checked
sparse for leon_kernel.c:
...
CHECK arch/sparc/kernel/of_device_32.c
arch/sparc/kernel/of_device_32.c:194:53: warning: incorrect type in argument 3 (different signedness)
arch/sparc/kernel/of_device_32.c:194:53: expected int *lenp
arch/sparc/kernel/of_device_32.c:194:53: got unsigned int *<noident>
CHECK arch/sparc/kernel/leon_kernel.c
CHECK arch/sparc/kernel/../../../kernel/irq/devres.c
CHECK arch/sparc/kernel/dma.c
arch/sparc/kernel/dma.c:97:6: warning: symbol 'dma32_unmap_sg' was not
declared. Should it be static?
...
sparse for leon_mm.c:
...
CHECK arch/sparc/mm/io-unit.c
arch/sparc/mm/io-unit.c:56:13: warning: incorrect type in assignment (different address spaces)
arch/sparc/mm/io-unit.c:56:13: expected unsigned long [usertype] *xpt
arch/sparc/mm/io-unit.c:56:13: got void [noderef] <asn:2>*
arch/sparc/mm/io-unit.c:256:13: warning: symbol 'ld_mmu_iounit' was not declared. Should it be static?
CHECK arch/sparc/mm/leon_mm.c
CHECK arch/sparc/mm/highmem.c
...
-- Greetings Konrad
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
