Hi Konrad.
> sparc-leon patches round 3 as reply to this thread soon.
This is getting in better and better shape.
A final round and I think they are ready for the eyes of David Miller.
General items:
git am told me:
===================================
Applying: sparc,leon: CONFIG_SPARC_LEON option and leon specific files.
/home/sam/kernel/linux-2.6.git/.git/rebase-apply/patch:29: trailing whitespace.
from www.gaisler.com. You can download a sparc-linux cross-compilation
/home/sam/kernel/linux-2.6.git/.git/rebase-apply/patch:31: trailing whitespace.
/home/sam/kernel/linux-2.6.git/.git/rebase-apply/patch:366: trailing whitespace.
#define leon_init()
warning: 3 lines add whitespace errors.
Applying: sparc,leon: Redefine MMU register access asi if CONFIG_LEON
Applying: sparc,leon: Introduce the sparc-leon CPU type.
Applying: sparc,leon: Added support for AMBAPP bus.
/home/sam/kernel/linux-2.6.git/.git/rebase-apply/patch:168: trailing whitespace.
warning: 1 line adds whitespace errors.
Applying: sparc,leon: sparc-leon specific SRMMU initialization and bootup fixes.
/home/sam/kernel/linux-2.6.git/.git/rebase-apply/patch:24: trailing whitespace.
/home/sam/kernel/linux-2.6.git/.git/rebase-apply/patch:81: trailing whitespace.
/home/sam/kernel/linux-2.6.git/.git/rebase-apply/patch:88: trailing whitespace.
warning: 3 lines add whitespace errors.
===================================
This needs fixing.
I also tried to run checkpatch - it told me:
total: 8 errors, 30 warnings, 1444 lines checked
Some of these needs fixing.
The ones where it complains about "over 80 characters" you
shall take intelligent decisions.
Do not blindly shorten lines.
The ones flagged ERROR needs fixing all of them.
Try it on the individual patches you submitted.
scripts/checpatch.pl name-of-patch
Have you tried to run sparse?
It may flag potential stuff that needs fixing too.
Sam
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
